Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1131173005: Improve documentation of CertVerifier::Verify() regarding |out_req|. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve documentation of CertVerifier::Verify() regarding |out_req|. Also adds DISALLOW_COPY() to Request. BUG=475153 Committed: https://crrev.com/9ef2155288547276afebfed59fc144402c286370 Cr-Commit-Position: refs/heads/master@{#330840}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase onto master #

Patch Set 4 : fix, and verify compiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M net/cert/cert_verifier.h View 1 2 3 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
eroman
5 years, 7 months ago (2015-05-15 03:05:42 UTC) #2
pneubeck (no reviews)
On 2015/05/15 03:05:42, eroman (sick slow) wrote: Sorry, I think my original comment was written ...
5 years, 7 months ago (2015-05-15 09:19:35 UTC) #3
eroman
Done, thanks
5 years, 7 months ago (2015-05-19 19:43:14 UTC) #4
pneubeck (no reviews)
lgtm
5 years, 7 months ago (2015-05-20 07:56:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131173005/60001
5 years, 7 months ago (2015-05-20 21:42:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 23:33:11 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:34:33 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9ef2155288547276afebfed59fc144402c286370
Cr-Commit-Position: refs/heads/master@{#330840}

Powered by Google App Engine
This is Rietveld 408576698