Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1131173004: Removing whispernet_client() by merging its functionality with GetWhispernetClient(). (Closed)

Created:
5 years, 7 months ago by Deepak
Modified:
5 years, 7 months ago
Reviewers:
rkc, Charlie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing whispernet_client() by merging its functionality with GetWhispernetClient(). Currently GetWhispernetClient() internally calls whispernet_client(), so functionality of whicpernet_client() moved to GetWhispernetClient(). and whispernet_client() removed. BUG=487175 Committed: https://crrev.com/ce403422b4a1e312849a4a0d7977758998b37068 Cr-Commit-Position: refs/heads/master@{#329428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_api.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Deepak
PTAL this small change. Thanks
5 years, 7 months ago (2015-05-12 11:09:26 UTC) #2
rkc
Charlie owns all this now.
5 years, 7 months ago (2015-05-12 15:02:25 UTC) #4
Charlie
lgtm
5 years, 7 months ago (2015-05-12 17:14:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131173004/1
5 years, 7 months ago (2015-05-12 17:14:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 17:18:59 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce403422b4a1e312849a4a0d7977758998b37068 Cr-Commit-Position: refs/heads/master@{#329428}
5 years, 7 months ago (2015-05-12 17:19:54 UTC) #9
Deepak
5 years, 7 months ago (2015-05-13 06:44:20 UTC) #10
Message was sent while issue was closed.
On 2015/05/12 17:14:19, Charlie wrote:
> lgtm

Thanks Charlie.

Powered by Google App Engine
This is Rietveld 408576698