Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1131153003: Add category selector to feedback dialog. (Closed)

Created:
5 years, 7 months ago by Jamie
Modified:
5 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add category selector to feedback dialog. * Add a <select> element to the dialog allowing the user to choose a category, or "other". * Disable the OK button and hide the reset options until a category is selected. * Clean up some duplicated code now that this dialog depends on base.js. BUG=b/20950552 Committed: https://crrev.com/1a814c9ea20387180c97adf639e47b9c4ae01392 Cr-Commit-Position: refs/heads/master@{#329784}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -11 lines) Patch
M remoting/resources/remoting_strings.grd View 1 chunk +25 lines, -1 line 2 comments Download
M remoting/webapp/app_remoting/html/feedback_consent.css View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/app_remoting/html/template_feedback_consent.html View 2 chunks +14 lines, -3 lines 0 comments Download
M remoting/webapp/app_remoting/js/feedback_consent.js View 5 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jamie
ptal
5 years, 7 months ago (2015-05-13 21:55:49 UTC) #2
kelvinp
https://codereview.chromium.org/1131153003/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/1131153003/diff/1/remoting/resources/remoting_strings.grd#newcode509 remoting/resources/remoting_strings.grd:509: <message desc="Category indicating that the user is having problems ...
5 years, 7 months ago (2015-05-13 22:40:04 UTC) #3
Jamie
https://codereview.chromium.org/1131153003/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/1131153003/diff/1/remoting/resources/remoting_strings.grd#newcode509 remoting/resources/remoting_strings.grd:509: <message desc="Category indicating that the user is having problems ...
5 years, 7 months ago (2015-05-13 23:15:06 UTC) #4
kelvinp
lgtm
5 years, 7 months ago (2015-05-14 01:24:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131153003/1
5 years, 7 months ago (2015-05-14 01:36:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 02:23:59 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 02:24:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a814c9ea20387180c97adf639e47b9c4ae01392
Cr-Commit-Position: refs/heads/master@{#329784}

Powered by Google App Engine
This is Rietveld 408576698