lib/src/codegen/html_codegen.dart - Issue 1131143002: Angular workarounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/html_codegen.dart

Issue 1131143002: Angular workarounds (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Rebase on latest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/html_codegen.dart

diff --git a/lib/src/codegen/html_codegen.dart b/lib/src/codegen/html_codegen.dart

index f8641c0d6383eeb2824bbe43ea6cee3238c29957..7eca73f63462ee4786eacd616aa49fb3ebae51e7 100644

--- a/lib/src/codegen/html_codegen.dart

+++ b/lib/src/codegen/html_codegen.dart

@@ -90,7 +90,9 @@ Node _cssInclude(String cssUrl) =>

Node _invokeMain(String mainLibraryName) {

var code = mainLibraryName == null

? 'console.error("dev_compiler error: main was not generated");'

- : '$mainLibraryName.main();';

+ // TODO(vsm): Can we simplify this?

+ // See: https://github.com/dart-lang/dev_compiler/issues/164

+ : '_isolate_helper.startRootIsolate($mainLibraryName.main, []);';

return parseFragment('<script>$code</script>\n');

}