Angular workarounds

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
@@ skipping 693 matching lines @@
           body.add(_overrideField(field));
         }
       }
     }
 
     // Static fields
     var lazyStatics = <VariableDeclaration>[];
     for (FieldDeclaration member in staticFields) {
       for (VariableDeclaration field in member.fields.variables) {
         var fieldName = field.name.name;
-        if ((field.isConst || _isFieldInitConstant(field)) &&
+        // TODO(vsm): This is a workaround until this is fixed:
+        // https://github.com/dart-lang/dev_compiler/issues/131
+        if ((/*field.isConst || */ _isFieldInitConstant(field)) &&
             !JS.invalidStaticFieldName(fieldName)) {
           var init = _visit(field.initializer);
           if (init == null) init = new JS.LiteralNull();
+          fieldName = _emitMemberName(fieldName, isStatic: true);
           body.add(js.statement('#.# = #;', [name, fieldName, init]));
         } else {
           lazyStatics.add(field);
         }
       }
     }
     var lazy = _emitLazyFields(new JS.Identifier(name), lazyStatics);
     if (lazy != null) body.add(lazy);
     return _statement(body);
   }
@@ skipping 1321 matching lines @@
         return js.call(
             'dart.$dynamicHelper(#, #)', [_visit(target), _visitList(args)]);
       }
       return js.call('dart.$DSEND(#, #, #)', [
         _visit(target),
         memberName,
         _visitList(args)
       ]);
     }
 
-    if (_isJSBuiltinType(type)) {
-      // static call pattern for builtins.
-      return js.call('#.#(#, #)', [
-        _emitTypeName(type),
-        memberName,
-        _visit(target),
-        _visitList(args)
-      ]);
-    }
     // Generic dispatch to a statically known method.
     return js.call('#.#(#)', [_visit(target), memberName, _visitList(args)]);
   }
 
   @override
   visitIndexExpression(IndexExpression node) {
     return _emitSend(_getTarget(node), '[]', [node.index]);
   }
 
   /// Gets the target of a [PropertyAccess] or [IndexExpression].
@@ skipping 296 matching lines @@
   @override
   visitNode(AstNode node) {
     // TODO(jmesserly): verify this is unreachable.
     throw 'Unimplemented ${node.runtimeType}: $node';
   }
 
   // TODO(jmesserly): this is used to determine if the field initialization is
   // side effect free. We should make the check more general, as things like
   // list/map literals/regexp are also side effect free and fairly common
   // to use as field initializers.
-  bool _isFieldInitConstant(VariableDeclaration field) =>
-      field.initializer == null || _computeConstant(field).isValid;
+  // TODO(vsm): Restore once this is fixed:
+  // https://github.com/dart-lang/dev_compiler/issues/131
+  bool _isFieldInitConstant(VariableDeclaration field) {
+    var initializer = field.initializer;
+    if (initializer == null) return true;
+    if (field.isConst || _computeConstant(field).isValid) {
+      return initializer is Literal && initializer is! TypedLiteral;
+    }
+    return false;
+  }
 
   EvaluationResult _computeConstant(VariableDeclaration field) {
     // If the constant is already computed by ConstantEvaluator, just return it.
     VariableElementImpl element = field.element;
     var result = element.evaluationResult;
     if (result != null) return result;
 
     // ConstantEvaluator will not compute constants for non-const fields
     // at least for cases like `int x = 0;`, so run ConstantVisitor for those.
     // TODO(jmesserly): ideally we'd only do this if we're sure it was skipped
@@ skipping 216 matching lines @@
 // TODO(jmesserly): validate the library. See issue #135.
 bool _isJsNameAnnotation(DartObjectImpl value) => value.type.name == 'JsName';
 
 bool _isJsPeerInterface(DartObjectImpl value) =>
     value.type.name == 'JsPeerInterface';
 
 // TODO(jacobr): we would like to do something like the following
 // but we don't have summary support yet.
 // bool _supportJsExtensionMethod(AnnotatedNode node) =>
 //    _getAnnotation(node, "SupportJsExtensionMethod") != null;