Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1131123003: Fix Heap::AllocateFillerObject() to use double alignment param. (Closed)

Created:
5 years, 7 months ago by paul.l...
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Heap::AllocateFillerObject() to use double alignment param. This is called from Runtime, and was dropping the requested alignment for doubles. Needed for upcoming MIPS CL to remove some more workarounds for load/store doubles. BUG= Committed: https://crrev.com/cbfb7cc1b16fa04f4d72fcc9119066b6d3c92e2c Cr-Commit-Position: refs/heads/master@{#28413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 7 months ago (2015-05-15 06:26:45 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-15 06:30:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131123003/1
5 years, 7 months ago (2015-05-15 06:31:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 06:49:55 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 06:50:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbfb7cc1b16fa04f4d72fcc9119066b6d3c92e2c
Cr-Commit-Position: refs/heads/master@{#28413}

Powered by Google App Engine
This is Rietveld 408576698