Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1131113007: Fix missing dependency in native_viewport_application_delegate.h (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing dependency in native_viewport_application_delegate.h Saw a build error in http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/38730/steps/compile/logs/stdio Committed: https://crrev.com/a27c2081e7658ab2b6d2dba46b681ca9b6b52029 Cr-Commit-Position: refs/heads/master@{#330385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/native_viewport/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 7 months ago (2015-05-18 16:56:02 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-18 17:01:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131113007/1
5 years, 7 months ago (2015-05-18 17:03:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:12:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a27c2081e7658ab2b6d2dba46b681ca9b6b52029
Cr-Commit-Position: refs/heads/master@{#330385}

Powered by Google App Engine
This is Rietveld 408576698