sync/internal_api/public/sessions/sync_session_snapshot.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/sessions/sync_session_snapshot.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/setup/daemon_controller_delegate_win.cc ('K') | « sync/internal_api/public/engine/model_safe_worker.cc ('k') | sync/js/js_event_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/sessions/sync_session_snapshot.cc

diff --git a/sync/internal_api/public/sessions/sync_session_snapshot.cc b/sync/internal_api/public/sessions/sync_session_snapshot.cc

index 33808826527b230e7c1336d2bb5dd559eba62358..c733f35a5675f4099d9aa2e38886e18a2d4880d1 100644

--- a/sync/internal_api/public/sessions/sync_session_snapshot.cc

+++ b/sync/internal_api/public/sessions/sync_session_snapshot.cc

@@ -103,7 +103,7 @@ scoped_ptr<base::DictionaryValue> SyncSessionSnapshot::ToValue() const {

std::string SyncSessionSnapshot::ToString() const {

std::string json;

base::JSONWriter::WriteWithOptions(

- ToValue().get(), base::JSONWriter::OPTIONS_PRETTY_PRINT, &json);

+ *ToValue(), base::JSONWriter::OPTIONS_PRETTY_PRINT, &json);

return json;

}

« remoting/host/setup/daemon_controller_delegate_win.cc ('K') | « sync/internal_api/public/engine/model_safe_worker.cc ('k') | sync/js/js_event_details.cc » ('j') | no next file with comments »