Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix platform specific stuff Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/pdfium/pdfium_engine.cc
diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
index b1b83a41ff5a776178746fe110f25dbb8be0073b..4351b14ebb6c5b3592e5b352e95d9526fa4efc9c 100644
--- a/pdf/pdfium/pdfium_engine.cc
+++ b/pdf/pdfium/pdfium_engine.cc
@@ -2445,7 +2445,7 @@ std::string PDFiumEngine::GetPageAsJSON(int index) {
scoped_ptr<base::Value> node(
pages_[index]->GetAccessibleContentAsValue(current_rotation_));
std::string page_json;
- base::JSONWriter::Write(node.get(), &page_json);
+ base::JSONWriter::Write(*node, &page_json);
return page_json;
}

Powered by Google App Engine
This is Rietveld 408576698