net/log/trace_net_log_observer.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/trace_net_log_observer.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/log/trace_net_log_observer.cc

diff --git a/net/log/trace_net_log_observer.cc b/net/log/trace_net_log_observer.cc

index 2ce8bc07ff2ea3acab57de93e4b2ca0095c9058e..4978e64c79e32ac7adb39bd736eebfa6d7cb137f 100644

--- a/net/log/trace_net_log_observer.cc

+++ b/net/log/trace_net_log_observer.cc

@@ -32,7 +32,7 @@ class TracedValue : public base::trace_event::ConvertableToTraceFormat {

void AppendAsTraceFormat(std::string* out) const override {

if (value_) {

std::string tmp;

- base::JSONWriter::Write(value_.get(), &tmp);

+ base::JSONWriter::Write(*value_, &tmp);

*out += tmp;

} else {

*out += "\"\"";

« no previous file with comments | « net/log/test_net_log_entry.cc ('k') | net/log/write_to_file_net_log_observer.cc » ('j') | remoting/host/setup/daemon_controller_delegate_win.cc » ('J')