net/http/http_network_transaction_unittest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/cast/test/simulator.cc ('k') | net/http/http_server_properties_manager_unittest.cc » ('j') | remoting/host/setup/daemon_controller_delegate_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_network_transaction_unittest.cc

diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc

index 88e3d276338de528faf996bc56001372d0456cda..4c36de7ebecb99dc6df6e761e997ca90d160bf7b 100644

--- a/net/http/http_network_transaction_unittest.cc

+++ b/net/http/http_network_transaction_unittest.cc

@@ -127,7 +127,7 @@ bool GetHeaders(base::DictionaryValue* params, std::string* headers) {

if (!params->GetList("headers", &header_list))

return false;

std::string double_quote_headers;

- base::JSONWriter::Write(header_list, &double_quote_headers);

+ base::JSONWriter::Write(*header_list, &double_quote_headers);

base::ReplaceChars(double_quote_headers, "\"", "'", headers);

return true;

}