content/shell/renderer/test_runner/test_interfaces.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/test_interfaces.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/test_runner/test_interfaces.cc

diff --git a/content/shell/renderer/test_runner/test_interfaces.cc b/content/shell/renderer/test_runner/test_interfaces.cc

index a70ff059fcb989c3ab2db4e477c2d4fa6ea31e91..e9448010cfafdda4ec9427a26024bc766f6ef738 100644

--- a/content/shell/renderer/test_runner/test_interfaces.cc

+++ b/content/shell/renderer/test_runner/test_interfaces.cc

@@ -124,7 +124,7 @@ void TestInterfaces::ConfigureForTestWithURL(const blink::WebURL& test_url,

base::DictionaryValue settings;

settings.SetString("testPath", base::GetQuotedJSONString(spec));

std::string settings_string;

- base::JSONWriter::Write(&settings, &settings_string);

+ base::JSONWriter::Write(settings, &settings_string);

test_runner_->ShowDevTools(settings_string, std::string());

}

if (spec.find("/viewsource/") != std::string::npos) {

« no previous file with comments | « content/shell/renderer/layout_test/leak_detector.cc ('k') | dbus/values_util.cc » ('j') | remoting/host/setup/daemon_controller_delegate_win.cc » ('J')