components/webcrypto/test/test_helpers.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/test/test_helpers.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/webcrypto/jwk.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_mac.mm » ('j') | remoting/host/setup/daemon_controller_delegate_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webcrypto/test/test_helpers.cc

diff --git a/components/webcrypto/test/test_helpers.cc b/components/webcrypto/test/test_helpers.cc

index 76da7faa40579ceb53abdfbcc765084a5069b5bd..8e24c95f32485e535291d5966f647c67860f6a8f 100644

--- a/components/webcrypto/test/test_helpers.cc

+++ b/components/webcrypto/test/test_helpers.cc

@@ -168,7 +168,7 @@ std::vector<uint8_t> MakeJsonVector(const std::string& json_string) {

std::vector<uint8_t> MakeJsonVector(const base::DictionaryValue& dict) {

std::string json;

- base::JSONWriter::Write(&dict, &json);

+ base::JSONWriter::Write(dict, &json);

return MakeJsonVector(json);

}