chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix platform specific stuff Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/util.cc ('k') | chrome/test/chromedriver/chrome_launcher.cc » ('j') | remoting/host/setup/daemon_controller_delegate_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index 16e3df16b0d934e8f9b7353c85249bf8fa729b6f..37123cb6a985eb3e32d0fa36357f39095b7bec89 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -237,7 +237,7 @@ Status WebViewImpl::CallFunction(const std::string& frame,

const base::ListValue& args,

scoped_ptr<base::Value>* result) {

std::string json;

- base::JSONWriter::Write(&args, &json);

+ base::JSONWriter::Write(args, &json);

// TODO(zachconrad): Second null should be array of shadow host ids.

std::string expression = base::StringPrintf(

"(%s).apply(null, [null, %s, %s])",

@@ -763,7 +763,7 @@ Status GetNodeIdFromFunction(DevToolsClient* client,

bool* found_node,

int* node_id) {

std::string json;

- base::JSONWriter::Write(&args, &json);

+ base::JSONWriter::Write(args, &json);

// TODO(zachconrad): Second null should be array of shadow host ids.

std::string expression = base::StringPrintf(

"(%s).apply(null, [null, %s, %s, true])",