sync/syncable/nigori_util.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/nigori_util.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/nigori_util.cc

diff --git a/sync/syncable/nigori_util.cc b/sync/syncable/nigori_util.cc

index 1eb92277d33304e069a92dbbcce3c9a9ee1ad0a2..1ad509530a0c70dd664c63cc27da3cad0c683ba3 100644

--- a/sync/syncable/nigori_util.cc

+++ b/sync/syncable/nigori_util.cc

@@ -175,9 +175,8 @@ bool UpdateEntryWithEncryption(

if (VLOG_IS_ON(2)) {

scoped_ptr<base::DictionaryValue> value(entry->ToValue(NULL));

std::string info;

- base::JSONWriter::WriteWithOptions(value.get(),

- base::JSONWriter::OPTIONS_PRETTY_PRINT,

- &info);

+ base::JSONWriter::WriteWithOptions(

+ *value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &info);

DVLOG(2) << "Encrypting specifics of type "

<< ModelTypeToString(type)

<< " with content: "

« no previous file with comments | « sync/js/js_event_details.cc ('k') | sync/test/fake_server/fake_server_verifier.cc » ('j') | no next file with comments »