sync/api/sync_data.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/sync_data.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/api/sync_data.cc

diff --git a/sync/api/sync_data.cc b/sync/api/sync_data.cc

index 0dd567d64520f4b9d588fad8ca109c6b28af0143..d6c91528d188671ecfce80a429eb2def582e394a 100644

--- a/sync/api/sync_data.cc

+++ b/sync/api/sync_data.cc

@@ -155,10 +155,9 @@ std::string SyncData::ToString() const {

std::string type = ModelTypeToString(GetDataType());

std::string specifics;

- scoped_ptr<base::DictionaryValue> value(

- EntitySpecificsToValue(GetSpecifics()));

- base::JSONWriter::WriteWithOptions(

- value.get(), base::JSONWriter::OPTIONS_PRETTY_PRINT, &specifics);

+ base::JSONWriter::WriteWithOptions(*EntitySpecificsToValue(GetSpecifics()),

+ base::JSONWriter::OPTIONS_PRETTY_PRINT,

+ &specifics);

if (IsLocal()) {

SyncDataLocal sync_data_local(*this);

« no previous file with comments | « remoting/host/video_frame_recorder_host_extension.cc ('k') | sync/engine/traffic_logger.cc » ('j') | no next file with comments »