remoting/host/policy_watcher_unittest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/policy_watcher_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/native_messaging/native_messaging_writer.cc ('k') | remoting/host/setup/daemon_controller_delegate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/policy_watcher_unittest.cc

diff --git a/remoting/host/policy_watcher_unittest.cc b/remoting/host/policy_watcher_unittest.cc

index 1d683cbc51e66b31aed1e149e82655de1f5c3ddf..b9cbefd19d916f798ffabce6d7286b6a5d029fba 100644

--- a/remoting/host/policy_watcher_unittest.cc

+++ b/remoting/host/policy_watcher_unittest.cc

@@ -27,11 +27,11 @@ MATCHER_P(IsPolicies, dict, "") {

if (!equal) {

std::string actual_value;

base::JSONWriter::WriteWithOptions(

- arg, base::JSONWriter::OPTIONS_PRETTY_PRINT, &actual_value);

+ *arg, base::JSONWriter::OPTIONS_PRETTY_PRINT, &actual_value);

std::string expected_value;

base::JSONWriter::WriteWithOptions(

- dict, base::JSONWriter::OPTIONS_PRETTY_PRINT, &expected_value);

+ *dict, base::JSONWriter::OPTIONS_PRETTY_PRINT, &expected_value);

*result_listener << "Policies are not equal. ";

*result_listener << "Expected policy: " << expected_value << ". ";

« no previous file with comments | « remoting/host/native_messaging/native_messaging_writer.cc ('k') | remoting/host/setup/daemon_controller_delegate_win.cc » ('j') | no next file with comments »