remoting/host/native_messaging/native_messaging_pipe.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/native_messaging/native_messaging_pipe.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/it2me/it2me_native_messaging_host_unittest.cc ('k') | remoting/host/native_messaging/native_messaging_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/native_messaging/native_messaging_pipe.cc

diff --git a/remoting/host/native_messaging/native_messaging_pipe.cc b/remoting/host/native_messaging/native_messaging_pipe.cc

index 8521472df0873dfbba833d043a5925431cd67e2e..da204d17f76b137c850f5d94e8f5a1f5c34925ce 100644

--- a/remoting/host/native_messaging/native_messaging_pipe.cc

+++ b/remoting/host/native_messaging/native_messaging_pipe.cc

@@ -27,7 +27,7 @@ void NativeMessagingPipe::Start(

void NativeMessagingPipe::OnMessage(scoped_ptr<base::Value> message) {

std::string message_json;

- base::JSONWriter::Write(message.get(), &message_json);

+ base::JSONWriter::Write(*message, &message_json);

host_->OnMessage(message_json);

}