printing/printed_document.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printed_document.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/printed_document.cc

diff --git a/printing/printed_document.cc b/printing/printed_document.cc

index 62fbef8a4e5e532fee7ff6557a51cd2fcd0868e7..3b17eff05aa50940bb6c3e224a41ff7e164f35ce 100644

--- a/printing/printed_document.cc

+++ b/printing/printed_document.cc

@@ -78,7 +78,7 @@ void DebugDumpSettings(const base::string16& doc_name,

PrintSettingsToJobSettingsDebug(settings, &job_settings);

std::string settings_str;

base::JSONWriter::WriteWithOptions(

- &job_settings, base::JSONWriter::OPTIONS_PRETTY_PRINT, &settings_str);

+ job_settings, base::JSONWriter::OPTIONS_PRETTY_PRINT, &settings_str);

scoped_refptr<base::RefCountedMemory> data =

base::RefCountedString::TakeString(&settings_str);

blocking_runner->PostTask(

« no previous file with comments | « pdf/pdfium/pdfium_engine.cc ('k') | remoting/base/vlog_net_log.cc » ('j') | no next file with comments »