Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: google_apis/drive/drive_api_requests.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/value_builder.cc ('k') | google_apis/gaia/fake_gaia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_requests.cc
diff --git a/google_apis/drive/drive_api_requests.cc b/google_apis/drive/drive_api_requests.cc
index 5cd289a0231248e78c791740fa07bc0bb0069192..57a3ec116bafe25769ef37344ba7d06c7401da98 100644
--- a/google_apis/drive/drive_api_requests.cc
+++ b/google_apis/drive/drive_api_requests.cc
@@ -130,7 +130,7 @@ std::string CreateMultipartUploadMetadataJson(
AttachProperties(properties, &root);
std::string json_string;
- base::JSONWriter::Write(&root, &json_string);
+ base::JSONWriter::Write(root, &json_string);
return json_string;
}
@@ -417,7 +417,7 @@ bool FilesInsertRequest::GetContentData(std::string* upload_content_type,
root.SetString("title", title_);
AttachProperties(properties_, &root);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "FilesInsert data: " << *upload_content_type << ", ["
<< *upload_content << "]";
@@ -491,7 +491,7 @@ bool FilesPatchRequest::GetContentData(std::string* upload_content_type,
}
AttachProperties(properties_, &root);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "FilesPatch data: " << *upload_content_type << ", ["
<< *upload_content << "]";
@@ -545,7 +545,7 @@ bool FilesCopyRequest::GetContentData(std::string* upload_content_type,
if (!title_.empty())
root.SetString("title", title_);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "FilesCopy data: " << *upload_content_type << ", ["
<< *upload_content << "]";
return true;
@@ -755,7 +755,7 @@ bool ChildrenInsertRequest::GetContentData(std::string* upload_content_type,
base::DictionaryValue root;
root.SetString("id", id_);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "InsertResource data: " << *upload_content_type << ", ["
<< *upload_content << "]";
return true;
@@ -834,7 +834,7 @@ bool InitiateUploadNewFileRequest::GetContentData(
}
AttachProperties(properties_, &root);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "InitiateUploadNewFile data: " << *upload_content_type << ", ["
<< *upload_content << "]";
@@ -906,7 +906,7 @@ bool InitiateUploadExistingFileRequest::GetContentData(
return false;
*upload_content_type = util::kContentTypeApplicationJson;
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
DVLOG(1) << "InitiateUploadExistingFile data: " << *upload_content_type
<< ", [" << *upload_content << "]";
return true;
@@ -1158,7 +1158,7 @@ bool PermissionsInsertRequest::GetContentData(std::string* upload_content_type,
break;
}
root.SetString("value", value_);
- base::JSONWriter::Write(&root, upload_content);
+ base::JSONWriter::Write(root, upload_content);
return true;
}
« no previous file with comments | « extensions/common/value_builder.cc ('k') | google_apis/gaia/fake_gaia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698