extensions/browser/value_store/value_store_change.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/value_store_change.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.cc ('k') | extensions/browser/value_store/value_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/value_store/value_store_change.cc

diff --git a/extensions/browser/value_store/value_store_change.cc b/extensions/browser/value_store/value_store_change.cc

index 822c9b9ef1c2c1938ad78c48cfc883f85566ba46..904ec829e24ce81e26bb607c404c24633732942a 100644

--- a/extensions/browser/value_store/value_store_change.cc

+++ b/extensions/browser/value_store/value_store_change.cc

@@ -23,7 +23,7 @@ std::string ValueStoreChange::ToJson(

changes_value.SetWithoutPathExpansion(it->key(), change_value);

}

std::string json;

- base::JSONWriter::Write(&changes_value, &json);

+ base::JSONWriter::Write(changes_value, &json);

return json;

}

« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.cc ('k') | extensions/browser/value_store/value_store_unittest.cc » ('j') | no next file with comments »