extensions/browser/api/cast_channel/keep_alive_delegate.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/keep_alive_delegate.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_api.cc ('k') | extensions/browser/api/storage/settings_quota_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/keep_alive_delegate.cc

diff --git a/extensions/browser/api/cast_channel/keep_alive_delegate.cc b/extensions/browser/api/cast_channel/keep_alive_delegate.cc

index 73c356f45b0fea37155073bc45d70b78b5628f06..df23519a6b7b67c781b3d262d0b356ee94c5a5ee 100644

--- a/extensions/browser/api/cast_channel/keep_alive_delegate.cc

+++ b/extensions/browser/api/cast_channel/keep_alive_delegate.cc

@@ -68,7 +68,7 @@ CastMessage KeepAliveDelegate::CreateKeepAliveMessage(

output.set_namespace_(kHeartbeatNamespace);

base::DictionaryValue type_dict;

type_dict.SetString(kTypeNodeId, message_type);

- if (!base::JSONWriter::Write(&type_dict, output.mutable_payload_utf8())) {

+ if (!base::JSONWriter::Write(type_dict, output.mutable_payload_utf8())) {

LOG(ERROR) << "Failed to serialize dictionary.";

return output;

}