Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1859)

Unified Diff: dbus/values_util_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/values_util.cc ('k') | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/values_util_unittest.cc
diff --git a/dbus/values_util_unittest.cc b/dbus/values_util_unittest.cc
index 27ec2d0c9899e27d52c2c8a492d406ac9f939825..6abc56a717a0c85207c76ff2bf1636206d298b56 100644
--- a/dbus/values_util_unittest.cc
+++ b/dbus/values_util_unittest.cc
@@ -377,11 +377,9 @@ TEST(ValuesUtilTest, PopDoubleToIntDictionary) {
// Create the expected value.
base::DictionaryValue dictionary_value;
for (size_t i = 0; i != values.size(); ++i) {
- scoped_ptr<base::Value> key_value(new base::FundamentalValue(keys[i]));
std::string key_string;
- base::JSONWriter::Write(key_value.get(), &key_string);
- dictionary_value.SetWithoutPathExpansion(
- key_string, new base::FundamentalValue(values[i]));
+ base::JSONWriter::Write(base::FundamentalValue(keys[i]), &key_string);
+ dictionary_value.SetIntegerWithoutPathExpansion(key_string, values[i]);
}
// Pop a dictionary.
« no previous file with comments | « dbus/values_util.cc ('k') | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698