content/shell/renderer/layout_test/leak_detector.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/leak_detector.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/layout_test/leak_detector.cc

diff --git a/content/shell/renderer/layout_test/leak_detector.cc b/content/shell/renderer/layout_test/leak_detector.cc

index a00fdbaee4c2003d9f09b09229bff9eb6b9eed64..41645bb5ac6d158f26e98b0d156bd631dd22044e 100644

--- a/content/shell/renderer/layout_test/leak_detector.cc

+++ b/content/shell/renderer/layout_test/leak_detector.cc

@@ -85,7 +85,7 @@ void LeakDetector::onLeakDetectionComplete(

if (!detail.empty()) {

std::string detail_str;

- base::JSONWriter::Write(&detail, &detail_str);

+ base::JSONWriter::Write(detail, &detail_str);

report.detail = detail_str;

report.leaked = true;

}

« no previous file with comments | « content/shell/browser/shell_devtools_frontend.cc ('k') | content/shell/renderer/test_runner/test_interfaces.cc » ('j') | no next file with comments »