content/browser/devtools/protocol/devtools_protocol_browsertest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/protocol/devtools_protocol_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

index cbae68203b997084d18c8c2bc32a84b57c8a563e..573aca47dd27d3dd557e247aca0829a5f0297f92 100644

--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

@@ -39,7 +39,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,

command.Set(kParamsParam, params.release());

std::string json_command;

- base::JSONWriter::Write(&command, &json_command);

+ base::JSONWriter::Write(command, &json_command);

agent_host_->DispatchProtocolMessage(json_command);

base::MessageLoop::current()->Run();

}