components/search_engines/keyword_table.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/keyword_table.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/search_engines/keyword_table.cc

diff --git a/components/search_engines/keyword_table.cc b/components/search_engines/keyword_table.cc

index 3e21c1f91ec5aac6a28c3379adb3797614d3542b..7de6217f23982008ea3e682f6b47eb4b3c3a466a 100644

--- a/components/search_engines/keyword_table.cc

+++ b/components/search_engines/keyword_table.cc

@@ -100,7 +100,7 @@ void BindURLToStatement(const TemplateURLData& data,

for (size_t i = 0; i < data.alternate_urls.size(); ++i)

alternate_urls_value.AppendString(data.alternate_urls[i]);

std::string alternate_urls;

- base::JSONWriter::Write(&alternate_urls_value, &alternate_urls);

+ base::JSONWriter::Write(alternate_urls_value, &alternate_urls);

s->BindInt64(id_column, data.id);

s->BindString16(starting_column, data.short_name());

« no previous file with comments | « components/proximity_auth/client.cc ('k') | components/search_provider_logos/logo_cache.cc » ('j') | no next file with comments »