components/policy/core/common/policy_test_utils.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_test_utils.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/policy_loader_win_unittest.cc ('k') | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/policy_test_utils.cc

diff --git a/components/policy/core/common/policy_test_utils.cc b/components/policy/core/common/policy_test_utils.cc

index 79180e41c288cd34c837a1daf7ece3f486ee9bd0..e9116b768769cb49e4e449367646d2239ce72881 100644

--- a/components/policy/core/common/policy_test_utils.cc

+++ b/components/policy/core/common/policy_test_utils.cc

@@ -222,9 +222,8 @@ std::ostream& operator<<(std::ostream& os, const policy::PolicyMap& policies) {

std::ostream& operator<<(std::ostream& os, const policy::PolicyMap::Entry& e) {

std::string value;

- base::JSONWriter::WriteWithOptions(e.value,

- base::JSONWriter::OPTIONS_PRETTY_PRINT,

- &value);

+ base::JSONWriter::WriteWithOptions(

+ *e.value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &value);

os << "{" << std::endl

<< " \"level\": " << e.level << "," << std::endl

<< " \"scope\": " << e.scope << "," << std::endl