components/omnibox/search_suggestion_parser.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/search_suggestion_parser.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/renderer/ppb_nacl_private_impl.cc ('k') | components/policy/core/common/cloud/policy_header_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/search_suggestion_parser.cc

diff --git a/components/omnibox/search_suggestion_parser.cc b/components/omnibox/search_suggestion_parser.cc

index 96933cf648040ae4a386908db7bdeb5a0a3e485b..26d1933ea024ade7f4bdf5169848058b5f371e44 100644

--- a/components/omnibox/search_suggestion_parser.cc

+++ b/components/omnibox/search_suggestion_parser.cc

@@ -518,7 +518,7 @@ bool SearchSuggestionParser::ParseSuggestResults(

answer->AddImageURLsTo(&results->answers_image_urls);

std::string contents;

- base::JSONWriter::Write(answer_json, &contents);

+ base::JSONWriter::Write(*answer_json, &contents);

answer_contents = base::UTF8ToUTF16(contents);

} else {

answer_type_str = base::string16();

« no previous file with comments | « components/nacl/renderer/ppb_nacl_private_impl.cc ('k') | components/policy/core/common/cloud/policy_header_service.cc » ('j') | no next file with comments »