Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: components/invalidation/invalidation_util.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/invalidation_test_util.cc ('k') | components/invalidation/p2p_invalidator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/invalidation_util.cc
diff --git a/components/invalidation/invalidation_util.cc b/components/invalidation/invalidation_util.cc
index 50e3a5c4908f39f63401b9379f8363f3e3b7b46e..d3706f48b73890b0878db9bce579e0e48886d78f 100644
--- a/components/invalidation/invalidation_util.cc
+++ b/components/invalidation/invalidation_util.cc
@@ -61,9 +61,8 @@ bool ObjectIdFromValue(const base::DictionaryValue& value,
}
std::string ObjectIdToString(const invalidation::ObjectId& object_id) {
- scoped_ptr<base::DictionaryValue> value(ObjectIdToValue(object_id));
std::string str;
- base::JSONWriter::Write(value.get(), &str);
+ base::JSONWriter::Write(*ObjectIdToValue(object_id), &str);
return str;
}
« no previous file with comments | « components/invalidation/invalidation_test_util.cc ('k') | components/invalidation/p2p_invalidator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698