components/history/core/browser/delete_directive_handler.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/delete_directive_handler.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/error_page/renderer/net_error_helper_core_unittest.cc ('k') | components/history/core/browser/web_history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/delete_directive_handler.cc

diff --git a/components/history/core/browser/delete_directive_handler.cc b/components/history/core/browser/delete_directive_handler.cc

index 0aba13ff5a9bdbb6325acf238f6442804eb60bbd..71d7f03a60e30da322e32792ffee1238bccac997 100644

--- a/components/history/core/browser/delete_directive_handler.cc

+++ b/components/history/core/browser/delete_directive_handler.cc

@@ -32,7 +32,7 @@ std::string DeleteDirectiveToString(

scoped_ptr<base::DictionaryValue> value(

syncer::HistoryDeleteDirectiveSpecificsToValue(delete_directive));

std::string str;

- base::JSONWriter::Write(value.get(), &str);

+ base::JSONWriter::Write(*value, &str);

return str;

}