components/autofill/content/browser/wallet/wallet_client.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/wallet/wallet_client.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cloud_print/service/win/service_listener.cc ('k') | components/autofill/content/browser/wallet/wallet_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/wallet/wallet_client.cc

diff --git a/components/autofill/content/browser/wallet/wallet_client.cc b/components/autofill/content/browser/wallet/wallet_client.cc

index b5cd15ec4a9d961c752196cd612b1613f4af7b96..e599b2e193b8488d6e7cb53bf2777cdaa700f7dd 100644

--- a/components/autofill/content/browser/wallet/wallet_client.cc

+++ b/components/autofill/content/browser/wallet/wallet_client.cc

@@ -295,7 +295,7 @@ void WalletClient::AuthenticateInstrument(

request_dict.SetString(kInstrumentIdKey, instrument_id);

std::string json_payload;

- base::JSONWriter::Write(&request_dict, &json_payload);

+ base::JSONWriter::Write(request_dict, &json_payload);

std::string escaped_card_verification_number = net::EscapeUrlEncodedData(

card_verification_number, true);

@@ -339,7 +339,7 @@ void WalletClient::GetFullWallet(const FullWalletRequest& full_wallet_request) {

request_dict.Set(kRiskCapabilitiesKey, risk_capabilities_list.release());

std::string json_payload;

- base::JSONWriter::Write(&request_dict, &json_payload);

+ base::JSONWriter::Write(request_dict, &json_payload);

crypto::RandBytes(&(one_time_pad_[0]), one_time_pad_.size());

@@ -431,7 +431,7 @@ void WalletClient::SaveToWallet(

}

std::string json_payload;

- base::JSONWriter::Write(&request_dict, &json_payload);

+ base::JSONWriter::Write(request_dict, &json_payload);

if (!card_verification_number.empty()) {

std::string post_body;

@@ -476,7 +476,7 @@ void WalletClient::GetWalletItems(const base::string16& amount,

request_dict.SetString(kTransactionCurrencyKey, currency);

std::string post_body;

- base::JSONWriter::Write(&request_dict, &post_body);

+ base::JSONWriter::Write(request_dict, &post_body);

MakeWalletRequest(GetGetWalletItemsUrl(user_index_),

post_body,

@@ -515,7 +515,7 @@ void WalletClient::DoAcceptLegalDocuments(

request_dict.Set(kAcceptedLegalDocumentKey, docs_list.release());

std::string post_body;

- base::JSONWriter::Write(&request_dict, &post_body);

+ base::JSONWriter::Write(request_dict, &post_body);

MakeWalletRequest(GetAcceptLegalDocumentsUrl(user_index_),

post_body,