Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: cloud_print/service/win/chrome_launcher.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cloud_print/service/service_state.cc ('k') | cloud_print/service/win/service_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/win/chrome_launcher.cc
diff --git a/cloud_print/service/win/chrome_launcher.cc b/cloud_print/service/win/chrome_launcher.cc
index adf9c24de363e899aea62edb146d7c70d6b7ba52..e9bcee10f055ebcc3b6b5d01be70075fcb12e8ad 100644
--- a/cloud_print/service/win/chrome_launcher.cc
+++ b/cloud_print/service/win/chrome_launcher.cc
@@ -133,7 +133,7 @@ std::string ReadAndUpdateServiceState(const base::FilePath& directory,
if (!proxy_id.empty()) // Reuse proxy id if we already had one.
dictionary->SetString(prefs::kCloudPrintProxyId, proxy_id);
std::string result;
- base::JSONWriter::WriteWithOptions(dictionary,
+ base::JSONWriter::WriteWithOptions(*dictionary,
base::JSONWriter::OPTIONS_PRETTY_PRINT,
&result);
return result;
@@ -276,7 +276,7 @@ std::string ChromeLauncher::CreateServiceStateFile(
base::ListValue printer_list;
printer_list.AppendStrings(printers);
std::string printers_json;
- base::JSONWriter::Write(&printer_list, &printers_json);
+ base::JSONWriter::Write(printer_list, &printers_json);
size_t written = base::WriteFile(printers_file,
printers_json.c_str(),
printers_json.size());
« no previous file with comments | « cloud_print/service/service_state.cc ('k') | cloud_print/service/win/service_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698