cloud_print/gcp20/prototype/privet_http_server.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/privet_http_server.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/gcp20/prototype/privet_http_server.cc

diff --git a/cloud_print/gcp20/prototype/privet_http_server.cc b/cloud_print/gcp20/prototype/privet_http_server.cc

index c0334395dbb29e065bc895558a80ea3cde310c07..90b45a8c647d3713df16b4a59d2f08113197a01d 100644

--- a/cloud_print/gcp20/prototype/privet_http_server.cc

+++ b/cloud_print/gcp20/prototype/privet_http_server.cc

@@ -234,7 +234,7 @@ net::HttpStatusCode PrivetHttpServer::ProcessHttpRequest(

return status_code;

}

- base::JSONWriter::WriteWithOptions(json_response.get(),

+ base::JSONWriter::WriteWithOptions(*json_response,

base::JSONWriter::OPTIONS_PRETTY_PRINT,

response);

return status_code;

« no previous file with comments | « cloud_print/gcp20/prototype/printer_state.cc ('k') | cloud_print/service/service_state.cc » ('j') | no next file with comments »