Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: cloud_print/gcp20/prototype/cloud_print_requester.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/shill_property_util.cc ('k') | cloud_print/gcp20/prototype/printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/gcp20/prototype/cloud_print_requester.cc
diff --git a/cloud_print/gcp20/prototype/cloud_print_requester.cc b/cloud_print/gcp20/prototype/cloud_print_requester.cc
index d46fdf4acc40028f6c87bd831d963b1998cc9331..cbfdae44caaa1d7195f90a8d4d0e5cfcd2b20ee9 100644
--- a/cloud_print/gcp20/prototype/cloud_print_requester.cc
+++ b/cloud_print/gcp20/prototype/cloud_print_requester.cc
@@ -86,10 +86,10 @@ std::string LocalSettingsToJson(const LocalSettings& settings) {
current->SetBoolean("printer/local_printing_enabled",
settings.local_printing_enabled);
current->SetInteger("xmpp_timeout_value", settings.xmpp_timeout_value);
- dictionary.Set("current", current.release());
+ dictionary.Set("current", current.Pass());
std::string local_settings;
- base::JSONWriter::Write(&dictionary, &local_settings);
+ base::JSONWriter::Write(dictionary, &local_settings);
return local_settings;
}
« no previous file with comments | « chromeos/network/shill_property_util.cc ('k') | cloud_print/gcp20/prototype/printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698