Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7437)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/util.cc ('k') | chrome/test/chromedriver/chrome_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index c9cce52b38f2a88327f2c0bbfdb97ffaa4fc778d..9febe2b742da5b6050fc08528c82ae93a60d21f1 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -237,7 +237,7 @@ Status WebViewImpl::CallFunction(const std::string& frame,
const base::ListValue& args,
scoped_ptr<base::Value>* result) {
std::string json;
- base::JSONWriter::Write(&args, &json);
+ base::JSONWriter::Write(args, &json);
// TODO(zachconrad): Second null should be array of shadow host ids.
std::string expression = base::StringPrintf(
"(%s).apply(null, [null, %s, %s])",
@@ -763,7 +763,7 @@ Status GetNodeIdFromFunction(DevToolsClient* client,
bool* found_node,
int* node_id) {
std::string json;
- base::JSONWriter::Write(&args, &json);
+ base::JSONWriter::Write(args, &json);
// TODO(zachconrad): Second null should be array of shadow host ids.
std::string expression = base::StringPrintf(
"(%s).apply(null, [null, %s, %s, true])",
« no previous file with comments | « chrome/test/chromedriver/chrome/util.cc ('k') | chrome/test/chromedriver/chrome_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698