Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/webui/policy_ui.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/policy_ui.cc
diff --git a/chrome/browser/ui/webui/policy_ui.cc b/chrome/browser/ui/webui/policy_ui.cc
index 32aa620785d2b719e101121dab6660ced3269c2d..03d43485804641fe4dced0da2ec12c88bcb51905 100644
--- a/chrome/browser/ui/webui/policy_ui.cc
+++ b/chrome/browser/ui/webui/policy_ui.cc
@@ -217,7 +217,7 @@ void ExtractDomainFromUsername(base::DictionaryValue* dict) {
// Utility function that returns a JSON serialization of the given |dict|.
scoped_ptr<base::StringValue> DictionaryToJSONString(
- const base::DictionaryValue* dict) {
+ const base::DictionaryValue& dict) {
std::string json_string;
base::JSONWriter::WriteWithOptions(dict,
base::JSONWriter::OPTIONS_PRETTY_PRINT,
@@ -230,14 +230,14 @@ scoped_ptr<base::StringValue> DictionaryToJSONString(
scoped_ptr<base::Value> CopyAndConvert(const base::Value* value) {
const base::DictionaryValue* dict = NULL;
if (value->GetAsDictionary(&dict))
- return DictionaryToJSONString(dict);
+ return DictionaryToJSONString(*dict);
scoped_ptr<base::Value> copy(value->DeepCopy());
base::ListValue* list = NULL;
if (copy->GetAsList(&list)) {
for (size_t i = 0; i < list->GetSize(); ++i) {
if (list->GetDictionary(i, &dict))
- list->Set(i, DictionaryToJSONString(dict).release());
+ list->Set(i, DictionaryToJSONString(*dict).release());
}
}

Powered by Google App Engine
This is Rietveld 408576698