chrome/browser/speech/extension_api/tts_engine_extension_api.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

index bc050e17c84965f2e3315e854f37de1b5edbd2c3..7e4071f516c0efaaf735ac804938cf68cfdfdf3b 100644

--- a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

@@ -191,7 +191,7 @@ void TtsExtensionEngine::Speak(Utterance* utterance,

args->AppendInteger(utterance->id());

std::string json;

- base::JSONWriter::Write(args.get(), &json);

+ base::JSONWriter::Write(*args, &json);

scoped_ptr<extensions::Event> event(new extensions::Event(

tts_engine_events::kOnSpeak, args.Pass()));

« no previous file with comments | « chrome/browser/safe_json_parser_browsertest.cc ('k') | chrome/browser/spellchecker/feedback_sender.cc » ('j') | no next file with comments »