chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/safe_json_parser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

index 6ac435dc6cb05c57ae7f74a1cc43790b88bab88f..60b460ad38c6033828013224b6fde2dc286cb0da 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

@@ -62,7 +62,7 @@ void PreferenceValidationDelegate::OnAtomicPreferenceValidation(

incident->set_path(pref_path);

if (!value ||

(!value->GetAsString(incident->mutable_atomic_value()) &&

- !base::JSONWriter::Write(value, incident->mutable_atomic_value()))) {

+ !base::JSONWriter::Write(*value, incident->mutable_atomic_value()))) {

incident->clear_atomic_value();

}

incident->set_value_state(proto_value_state);

« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/safe_json_parser_browsertest.cc » ('j') | no next file with comments »