chrome/browser/extensions/api/storage/settings_apitest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_apitest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api_helpers.cc ('k') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_apitest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_apitest.cc b/chrome/browser/extensions/api/storage/settings_apitest.cc

index eaa5ea1a9e7dccbcef455ab3718fb4d419dac089..50f03832c4738db1228ec127532e75d1472e0f2b 100644

--- a/chrome/browser/extensions/api/storage/settings_apitest.cc

+++ b/chrome/browser/extensions/api/storage/settings_apitest.cc

@@ -174,12 +174,12 @@ class ExtensionSettingsApiTest : public ExtensionApiTest {

Namespace settings_namespace,

const std::string& action,

bool is_final_action) {

- scoped_ptr<base::DictionaryValue> message(new base::DictionaryValue());

- message->SetString("namespace", ToString(settings_namespace));

- message->SetString("action", action);

- message->SetBoolean("isFinalAction", is_final_action);

+ base::DictionaryValue message;

+ message.SetString("namespace", ToString(settings_namespace));

+ message.SetString("action", action);

+ message.SetBoolean("isFinalAction", is_final_action);

std::string message_json;

- base::JSONWriter::Write(message.get(), &message_json);

+ base::JSONWriter::Write(message, &message_json);

return message_json;

}