chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl_unittest.cc ('k') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

index c6266a255f3cc2cab9e09c9489a20508c6a17fa1..c5e897f0e479731255cde3f10661f295705144df 100644

--- a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

@@ -51,7 +51,7 @@ std::string CrxIdToHashToCrxId(const std::string& kCrxId) {

return GetCrxComponentID(component);

}

-std::string JsonToString(const base::DictionaryValue* dict) {

+std::string JsonToString(const base::DictionaryValue& dict) {

std::string json;

base::JSONWriter::Write(dict, &json);

return json;

@@ -310,8 +310,8 @@ TEST_F(SupervisedUserWhitelistInstallerTest, InstallNewWhitelist) {

ASSERT_TRUE(base::ReadFileToString(whitelist_path_, &whitelist_contents));

EXPECT_EQ(kWhitelistContents, whitelist_contents);

- EXPECT_EQ(JsonToString(&pref_),

- JsonToString(local_state_.GetDictionary(

+ EXPECT_EQ(JsonToString(pref_),

+ JsonToString(*local_state_.GetDictionary(

prefs::kRegisteredSupervisedUserWhitelists)));

}