chrome/browser/chromeos/boot_times_recorder.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/boot_times_recorder.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc ('k') | chrome/browser/chromeos/extensions/accessibility_features_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/boot_times_recorder.cc

diff --git a/chrome/browser/chromeos/boot_times_recorder.cc b/chrome/browser/chromeos/boot_times_recorder.cc

index e9a3cecd456342f4628e9112bf48c7ae5261d6f5..268aef619d9cb37a40d6edd021fc1925185cb9e3 100644

--- a/chrome/browser/chromeos/boot_times_recorder.cc

+++ b/chrome/browser/chromeos/boot_times_recorder.cc

@@ -152,7 +152,7 @@ std::string BootTimesRecorder::Stats::SerializeToString() const {

dictionary.SetString(kDisk, disk_);

std::string result;

- if (!base::JSONWriter::Write(&dictionary, &result)) {

+ if (!base::JSONWriter::Write(dictionary, &result)) {

LOG(WARNING) << "BootTimesRecorder::Stats::SerializeToString(): failed.";

return std::string();

}