Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_data.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_data.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
index 5245aad495940b703167993d63812f8453df3f6a..22d73d390fd408fc908f64d90a2b412b58db5246 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
@@ -76,7 +76,7 @@ bool IsValidKioskAppManifest(const extensions::Manifest& manifest) {
return false;
}
-std::string ValueToString(const base::Value* value) {
+std::string ValueToString(const base::Value& value) {
std::string json;
base::JSONWriter::Write(value, &json);
return json;
@@ -602,7 +602,7 @@ void KioskAppData::OnWebstoreResponseParseSuccess(
icon_url_string);
if (!icon_url.is_valid()) {
LOG(ERROR) << "Webstore response error (icon url): "
- << ValueToString(webstore_data.get());
+ << ValueToString(*webstore_data);
OnWebstoreResponseParseFailure(kInvalidWebstoreResponseError);
return;
}
@@ -626,7 +626,7 @@ bool KioskAppData::CheckResponseKeyValue(const base::DictionaryValue* response,
std::string* value) {
if (!response->GetString(key, value)) {
LOG(ERROR) << "Webstore response error (" << key
- << "): " << ValueToString(response);
+ << "): " << ValueToString(*response);
OnWebstoreResponseParseFailure(kInvalidWebstoreResponseError);
return false;
}
« no previous file with comments | « chrome/browser/caps/generate_state_json.cc ('k') | chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698