base/trace_event/trace_event_system_stats_monitor.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_system_stats_monitor.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_system_stats_monitor.cc

diff --git a/base/trace_event/trace_event_system_stats_monitor.cc b/base/trace_event/trace_event_system_stats_monitor.cc

index 98f361a9d9ba1b94d20d736f1b414a3d2c9182cd..c08d9b9477aa58a903ae5a4570e9ff21b7a39dbe 100644

--- a/base/trace_event/trace_event_system_stats_monitor.cc

+++ b/base/trace_event/trace_event_system_stats_monitor.cc

@@ -125,7 +125,7 @@ bool TraceEventSystemStatsMonitor::IsTimerRunningForTest() const {

void AppendSystemProfileAsTraceFormat(const SystemMetrics& system_metrics,

std::string* output) {

std::string tmp;

- base::JSONWriter::Write(system_metrics.ToValue().get(), &tmp);

+ base::JSONWriter::Write(*system_metrics.ToValue(), &tmp);

*output += tmp;

}

« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | base/values.cc » ('j') | no next file with comments »