Convert JsonWriter::Write to taking a const ref for the in-param

chrome/browser/chromeos/app_mode/kiosk_app_data.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/app_mode/kiosk_app_data.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
@@ skipping 58 matching lines @@
 bool IsValidKioskAppManifest(const extensions::Manifest& manifest) {
   bool kiosk_enabled;
   if (manifest.GetBoolean(extensions::manifest_keys::kKioskEnabled,
                           &kiosk_enabled)) {
     return kiosk_enabled;
   }
 
   return false;
 }
 
-std::string ValueToString(const base::Value* value) {
+std::string ValueToString(const base::Value& value) {
   std::string json;
   base::JSONWriter::Write(value, &json);
   return json;
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // KioskAppData::CrxLoader
 // Loads meta data from crx file.
@@ skipping 505 matching lines @@
 
   std::string icon_url_string;
   if (!CheckResponseKeyValue(webstore_data.get(), kIconUrlKey,
                              &icon_url_string))
     return;
 
   GURL icon_url = GURL(extension_urls::GetWebstoreLaunchURL()).Resolve(
       icon_url_string);
   if (!icon_url.is_valid()) {
     LOG(ERROR) << "Webstore response error (icon url): "
-               << ValueToString(webstore_data.get());
+               << ValueToString(*webstore_data);
     OnWebstoreResponseParseFailure(kInvalidWebstoreResponseError);
     return;
   }
 
   // WebstoreDataParser deletes itself when done.
   (new WebstoreDataParser(AsWeakPtr()))->Start(app_id_,
                                                manifest,
                                                icon_url,
                                                GetRequestContextGetter());
 }
 
 void KioskAppData::OnWebstoreResponseParseFailure(const std::string& error) {
   LOG(ERROR) << "Webstore failed for kiosk app " << app_id_
              << ", " << error;
   webstore_fetcher_.reset();
   SetStatus(STATUS_ERROR);
 }
 
 bool KioskAppData::CheckResponseKeyValue(const base::DictionaryValue* response,
                                          const char* key,
                                          std::string* value) {
   if (!response->GetString(key, value)) {
     LOG(ERROR) << "Webstore response error (" << key
-               << "): " << ValueToString(response);
+               << "): " << ValueToString(*response);
     OnWebstoreResponseParseFailure(kInvalidWebstoreResponseError);
     return false;
   }
   return true;
 }
 
 void KioskAppData::MaybeLoadFromCrx() {
   if (status_ == STATUS_LOADED || crx_file_.empty())
     return;
 
@@ skipping 14 matching lines @@
 
   SkBitmap icon = crx_loader->icon();
   if (icon.empty())
     icon = *extensions::util::GetDefaultAppIcon().bitmap();
   SetCache(crx_loader->name(), icon);
 
   SetStatus(STATUS_LOADED);
 }
 
 }  // namespace chromeos