Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: content/browser/geolocation/network_location_provider_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_reader.h" 5 #include "base/json/json_reader.h"
6 #include "base/json/json_writer.h" 6 #include "base/json/json_writer.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 pos.latitude = id; 184 pos.latitude = id;
185 pos.longitude = -(id + 1); 185 pos.longitude = -(id + 1);
186 pos.altitude = 2 * id; 186 pos.altitude = 2 * id;
187 pos.timestamp = base::Time::Now(); 187 pos.timestamp = base::Time::Now();
188 return pos; 188 return pos;
189 } 189 }
190 190
191 static std::string PrettyJson(const base::Value& value) { 191 static std::string PrettyJson(const base::Value& value) {
192 std::string pretty; 192 std::string pretty;
193 base::JSONWriter::WriteWithOptions( 193 base::JSONWriter::WriteWithOptions(
194 &value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &pretty); 194 value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &pretty);
195 return pretty; 195 return pretty;
196 } 196 }
197 197
198 static testing::AssertionResult JsonGetList( 198 static testing::AssertionResult JsonGetList(
199 const std::string& field, 199 const std::string& field,
200 const base::DictionaryValue& dict, 200 const base::DictionaryValue& dict,
201 const base::ListValue** output_list) { 201 const base::ListValue** output_list) {
202 if (!dict.GetList(field, output_list)) 202 if (!dict.GetList(field, output_list))
203 return testing::AssertionFailure() << "Dictionary " << PrettyJson(dict) 203 return testing::AssertionFailure() << "Dictionary " << PrettyJson(dict)
204 << " is missing list field " << field; 204 << " is missing list field " << field;
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 EXPECT_TRUE(cache.FindPosition(CreateReferenceWifiScanData(1))); 548 EXPECT_TRUE(cache.FindPosition(CreateReferenceWifiScanData(1)));
549 } else { 549 } else {
550 const int evicted = i - kCacheSize; 550 const int evicted = i - kCacheSize;
551 EXPECT_FALSE(cache.FindPosition(CreateReferenceWifiScanData(evicted))); 551 EXPECT_FALSE(cache.FindPosition(CreateReferenceWifiScanData(evicted)));
552 EXPECT_TRUE(cache.FindPosition(CreateReferenceWifiScanData(evicted + 1))); 552 EXPECT_TRUE(cache.FindPosition(CreateReferenceWifiScanData(evicted + 1)));
553 } 553 }
554 } 554 }
555 } 555 }
556 556
557 } // namespace content 557 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.cc ('k') | content/browser/geolocation/network_location_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698