Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/test/chromedriver/chrome/console_logger.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/chrome/console_logger.h" 5 #include "chrome/test/chromedriver/chrome/console_logger.h"
6 6
7 #include "base/json/json_writer.h" 7 #include "base/json/json_writer.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 origin_cstr, 86 origin_cstr,
87 line_column.c_str(), 87 line_column.c_str(),
88 text.c_str())); 88 text.c_str()));
89 89
90 return Status(kOk); 90 return Status(kOk);
91 } 91 }
92 } 92 }
93 93
94 // Don't know how to format, log full JSON. 94 // Don't know how to format, log full JSON.
95 std::string message_json; 95 std::string message_json;
96 base::JSONWriter::Write(&params, &message_json); 96 base::JSONWriter::Write(params, &message_json);
97 log_->AddEntry(Log::kWarning, message_json); 97 log_->AddEntry(Log::kWarning, message_json);
98 return Status(kOk); 98 return Status(kOk);
99 } 99 }
OLDNEW
« no previous file with comments | « chrome/service/cloud_print/print_system_win.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698