Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_writer.h" 5 #include "base/json/json_writer.h"
6 #include "base/strings/string_split.h" 6 #include "base/strings/string_split.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_pr ivate_api.h" 8 #include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_pr ivate_api.h"
9 #include "chrome/browser/extensions/extension_apitest.h" 9 #include "chrome/browser/extensions/extension_apitest.h"
10 #include "chrome/browser/extensions/extension_function_test_utils.h" 10 #include "chrome/browser/extensions/extension_function_test_utils.h"
(...skipping 17 matching lines...) Expand all
28 28
29 namespace utils = extension_function_test_utils; 29 namespace utils = extension_function_test_utils;
30 30
31 namespace { 31 namespace {
32 32
33 static const char kTestLoggingSessionId[] = "0123456789abcdef"; 33 static const char kTestLoggingSessionId[] = "0123456789abcdef";
34 static const char kTestLoggingUrl[] = "dummy url string"; 34 static const char kTestLoggingUrl[] = "dummy url string";
35 35
36 std::string ParamsToString(const base::ListValue& parameters) { 36 std::string ParamsToString(const base::ListValue& parameters) {
37 std::string parameter_string; 37 std::string parameter_string;
38 EXPECT_TRUE(base::JSONWriter::Write(&parameters, &parameter_string)); 38 EXPECT_TRUE(base::JSONWriter::Write(parameters, &parameter_string));
39 return parameter_string; 39 return parameter_string;
40 } 40 }
41 41
42 void InitializeTestMetaData(base::ListValue* parameters) { 42 void InitializeTestMetaData(base::ListValue* parameters) {
43 base::DictionaryValue* meta_data_entry = new base::DictionaryValue(); 43 base::DictionaryValue* meta_data_entry = new base::DictionaryValue();
44 meta_data_entry->SetString("key", "app_session_id"); 44 meta_data_entry->SetString("key", "app_session_id");
45 meta_data_entry->SetString("value", kTestLoggingSessionId); 45 meta_data_entry->SetString("value", kTestLoggingSessionId);
46 base::ListValue* meta_data = new base::ListValue(); 46 base::ListValue* meta_data = new base::ListValue();
47 meta_data->Append(meta_data_entry); 47 meta_data->Append(meta_data_entry);
48 meta_data_entry = new base::DictionaryValue(); 48 meta_data_entry = new base::DictionaryValue();
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 ASSERT_TRUE(StoreLog(kLogId)); 386 ASSERT_TRUE(StoreLog(kLogId));
387 387
388 ScopedOverrideUploadBuffer buffer_override; 388 ScopedOverrideUploadBuffer buffer_override;
389 EXPECT_TRUE(UploadStoredLog(kLogId)); 389 EXPECT_TRUE(UploadStoredLog(kLogId));
390 EXPECT_NE(std::string::npos, 390 EXPECT_NE(std::string::npos,
391 buffer_override.multipart().find("filename=\"webrtc_log.gz\"")); 391 buffer_override.multipart().find("filename=\"webrtc_log.gz\""));
392 EXPECT_NE(std::string::npos, 392 EXPECT_NE(std::string::npos,
393 buffer_override.multipart().find(kTestLoggingUrl)); 393 buffer_override.multipart().find(kTestLoggingUrl));
394 } 394 }
395 395
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698