chrome/browser/extensions/api/messaging/message_property_provider.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/messaging/message_property_provider.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/messaging/message_property_provider.h"	5 #include "chrome/browser/extensions/api/messaging/message_property_provider.h"

6	6

7 #include "base/json/json_writer.h"	7 #include "base/json/json_writer.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/strings/string_piece.h"	9 #include "base/strings/string_piece.h"

10 #include "base/thread_task_runner_handle.h"	10 #include "base/thread_task_runner_handle.h"

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 if (!net::asn1::ExtractSPKIFromDERCert(output->domain_bound_cert, &spki)) {	93 if (!net::asn1::ExtractSPKIFromDERCert(output->domain_bound_cert, &spki)) {

94 original_task_runner->PostTask(FROM_HERE, no_tls_channel_id_closure);	94 original_task_runner->PostTask(FROM_HERE, no_tls_channel_id_closure);

95 return;	95 return;

96 }	96 }

97 base::DictionaryValue jwk_value;	97 base::DictionaryValue jwk_value;

98 if (!net::JwkSerializer::ConvertSpkiFromDerToJwk(spki, &jwk_value)) {	98 if (!net::JwkSerializer::ConvertSpkiFromDerToJwk(spki, &jwk_value)) {

99 original_task_runner->PostTask(FROM_HERE, no_tls_channel_id_closure);	99 original_task_runner->PostTask(FROM_HERE, no_tls_channel_id_closure);

100 return;	100 return;

101 }	101 }

102 std::string jwk_str;	102 std::string jwk_str;

103 base::JSONWriter::Write(&jwk_value, &jwk_str);	103 base::JSONWriter::Write(jwk_value, &jwk_str);

104 original_task_runner->PostTask(FROM_HERE, base::Bind(reply, jwk_str));	104 original_task_runner->PostTask(FROM_HERE, base::Bind(reply, jwk_str));

105 }	105 }

106	106

107 } // namespace extensions	107 } // namespace extensions

OLD	NEW