Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1131113003: [Extensions] Enable the "Report Abuse" checkbox in extension uninstall (Closed)

Created:
5 years, 7 months ago by Devlin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Enable the "Report Abuse" checkbox in extension uninstall After talking it over more, it's been decided that this should really just be enabled by default, rather than Finch'd. BUG=441377 Committed: https://crrev.com/263f6fa45aa0d6872ce9834ad04a418f08a587c8 Cr-Commit-Position: refs/heads/master@{#329908}

Patch Set 1 #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/extensions/extension_uninstall_dialog.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Devlin
Waiting on final go-ahead from Jake, but it looks like we're just gonna turn this ...
5 years, 7 months ago (2015-05-08 22:22:56 UTC) #2
not at google - send to devlin
It looks like the launch bug hasn't been approved? I read through the bug and ...
5 years, 7 months ago (2015-05-08 22:28:54 UTC) #3
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-05-08 23:13:38 UTC) #4
Devlin
On 2015/05/08 23:13:38, kalman wrote: > lgtm Per offline conversation, we're gonna go ahead with ...
5 years, 7 months ago (2015-05-08 23:14:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131113003/1
5 years, 7 months ago (2015-05-08 23:30:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:51:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131113003/20001
5 years, 7 months ago (2015-05-14 18:36:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 19:48:44 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 19:50:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/263f6fa45aa0d6872ce9834ad04a418f08a587c8
Cr-Commit-Position: refs/heads/master@{#329908}

Powered by Google App Engine
This is Rietveld 408576698