Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1131063005: Integration test for Lo-Fi directives in the Chrome-Proxy response header (Closed)

Created:
5 years, 7 months ago by megjablon
Modified:
5 years, 7 months ago
Reviewers:
sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Integration test for Lo-Fi directives in the Chrome-Proxy response header Lo-Fi directives were added to the Chrome-Proxy response header. Adding testing of these responses in the Lo-Fi integration test. BUG=487879 Committed: https://crrev.com/f2ba95e366d3dba58ee697f2a2ca7394b79cc645 Cr-Commit-Position: refs/heads/master@{#330006}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M tools/chrome_proxy/common/chrome_proxy_metrics.py View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 2 1 chunk +18 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
megjablon
5 years, 7 months ago (2015-05-14 00:08:23 UTC) #2
sclittle
LGTM with nit https://codereview.chromium.org/1131063005/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/1131063005/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode332 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:332: 'received.') nit: wording seems a bit ...
5 years, 7 months ago (2015-05-14 22:03:25 UTC) #3
megjablon
https://codereview.chromium.org/1131063005/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/1131063005/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode332 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:332: 'received.') On 2015/05/14 22:03:25, sclittle wrote: > nit: wording ...
5 years, 7 months ago (2015-05-15 00:38:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131063005/40001
5 years, 7 months ago (2015-05-15 01:09:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 01:16:01 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:17:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f2ba95e366d3dba58ee697f2a2ca7394b79cc645
Cr-Commit-Position: refs/heads/master@{#330006}

Powered by Google App Engine
This is Rietveld 408576698